Tg feb 1 parity PR #399
Merged
Tg feb 1 parity PR #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#89190) ## About The Pull Request Strips auto-labeling behavior from the webhook processor to an action. All that remains in the webhook processor is ingame PR announcements, "changelog validation" (which is either broken or we have disabled), and handling for "request review" (which we have disabled) Keywords have been maintained 1:1, unless I missed something or accidentally shoved something where it shouldn't be I wanted to link this to the changelog parser but that seems like a slightly larger project so I'll just throw this up as-is Note: I'm not very experienced in writing actions so review with scrutiny ## Why Actions are a lot easier to maintain and set up for downstreams Adding new labels should now be like, 10x easier since all you need to do is slap it in the config file Webhook processor is also kinda old an breaks semi-frequently ### (Tested)  
) ## About The Pull Request This makes it so `RECT_TURFS`, `Z_TURFS`, `ALL_TURFS`, and `CORNER_BLOCK_OFFSET` use 515's new `block(StartX,StartY,StartZ, EndX=StartX,EndY=StartY,EndZ=StartZ)` syntax, instead of block+locate. Also removes the `min`/`max` calls, someone in byondcord tested and confirmed that `block(x, y, z)` clamps to 1 and world.maxx/y/z/ ## Why It's Good For The Game less cluttered code is nice, and it should in theory be more optimized as we avoid the need to run min, max, and locate. ## Changelog no user-facing changes
## About The Pull Request Tiny code cleanup to AI-related files. - Removes unmaintained pointless block comment that listed file contents. - Updates file reference to where you actually need to add things. - Convert some heavily copy/pasted lists to defines. Originally implemented in tgstation#89032 and will conflict with it when merged presumably but that's my problem. @san7890 correctly noted that getting new AI laws merged can be tedious and political and he would like these changes to be mergeable separately. ## Changelog Not player facing
## About The Pull Request - removed manual rounding of the reagent holder's `total_volume` from wherever this var was used. It's already done by `update_total()` so this makes that code slightly faster - `add_reagent()` now won't return a false positive when adding reagent amounts less than 0.01 if that reagent was being added for the first time as it would get deleted immediately - `remove_reagent()` & `get_reagent_amount()` now also don't round their return value so you can work with more accurate values - `trans_to()` won't return a false negative when transferring amounts less than 0.01 even when the operation was successful. This also makes it slightly faster cause we no longer round the return value ## Changelog :cl: fix: adding/transferring reagent amounts less than 0.01 now won't return false results code: removed excessive rounding of reagent volumes thus slightly improving performance /:cl:
…nts out (tgstation#89228) ## About The Pull Request Closes tgstation#89217 ## Changelog :cl: fix: Fixed evidence bag not reverting to tiny size after dumping its contents out /:cl:
## About The Pull Request Fixes the fact that the justice mech dash could only be performed in eight main directions, which was clearly not intended, since you made a dash at the completely wrong place and not at the target. ## Why It's Good For The Game Fixes ability's weird behavior ## Changelog :cl: fix: Fixed Justice mech's dash ability /:cl:
## About The Pull Request  Fish trophies from persistence are meant to be dusted and thus drop no fillet. So we always need to be checking that we actually have a `fillet_type` before attempting to create one. Just fixes one spot that wasn't doing that. ## Why It's Good For The Game Annoying CI failures for no reason begone. ## Changelog :cl: fix: due to a number of complaints of fish explosions, chrystarfish will no longer be chosen as the random starting fish for the fish mount. /:cl:
Fixes a very large number of typos. A few of these fixes also extend to variable names, but only the really egregious ones like "concious".
…ion#89227) ## About The Pull Request Closes tgstation#89206 ## Changelog :cl: fix: Fixed crafting menu not changing the cursor when hovered over /:cl:
## About The Pull Request  Tin. These were hanging refs to the copied object ## Changelog N/A --------- Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
## About The Pull Request https://github.com/user-attachments/assets/a57e9bd2-8e00-4ab4-86de-9facba477955   Resprites medbots and related sprites - stacked mediborg skin, assemblies ## Why It's Good For The Game Consistent with the new medkits ## Changelog :cl: image: New medbot sprites image: New stacked medibot borg skin sprite /:cl:
## About The Pull Request Fishing UI has received a major glowup: https://github.com/user-attachments/assets/e255822c-9c2c-4e09-843d-20ea70f470f5 All fishing rods now have unique frames (with material rods' frames' colors being based on their material), and most fishing sources now have unique backgrounds. Completion bar now uses alpha filters, making it much smoother, and bait bar is assembled from thin lines, which allows us to avoid stretching it when we need to resize the bar. Fixed experiments not unlinking after being completed, resulting in infinitely stacking examine lines on advanced fishing rods. Fish death messages now use more fitting span_warning. Removed devious SS_POST_FIRE_TIMING from the fishing SS, as it made sometimes the fishing SS only fire every ***two*** ticks instead of every tick, despite passing 0.05s (1 tick) into its process() calls - this flag only makes sense on heavy and costly subsystems, not on a subsystem dedicated mostly to fishing minigames. This is required as now instead of directly assigning coordinates (why???) fishing UI uses animate() to control the bait bar and fish icons, making it much smoother. Also gave blue dough its own bait overlay and mansus rift its own portal icon because why not. ## Why It's Good For The Game Fishing UI didn't look very nice, and removing the subsystem flag makes the game smoother. ## Changelog :cl: qol: Fishing minigame should be smoother now fix: Fixed infinitely stacking examine lines on advanced fishing rods image: Resprited fishing UI image: Blue doughballs now have their own fishing rod overlay image: Resprited mansus rift fishing portal overlay /:cl:
## About The Pull Request x = x is silly ## Why It's Good For The Game fix ## Changelog :cl: fix: PDA ringtones can be changed in-game /:cl:
## About The Pull Request - Fixes tgstation#89242 - Fixes balloon alert runtime when the assembly is secured & the holder cannot be attached ## Changelog :cl: fix: fixes balloon alert runtimes with assembly holder /:cl:
…on#89253) ## About The Pull Request This sets the processing subsystem for `/datum/status_effect/fire_handler` to use `STATUS_EFFECT_PRIORITY` (`SSpriority_effects`) ## Why It's Good For The Game I'd say being on fire is classified under "certain status effects that'd fuck the player over from lasting much longer due to server load" ## Changelog :cl: fix: Being on fire or wet should no longer last much longer than intended while the server is under load. /:cl:
## About The Pull Request Commit messages should be descriptive of all changes. The "incorrect `\The` macro capitalization" was intentional when it was added, but as far as I know TG says "the supermatter" rather than "The Supermatter," so it's incorrect now. This is completely untested. I don't even know how you'd go about testing this, it's just a fuckton of strings. Someday I want to extract them and run NLP on it to catch grammar problems... ## Why It's Good For The Game Basic grammar pass for name strings. Should make `\the` work better and avoid cases like `the John Smith`.
## About The Pull Request   ## Changelog :cl: fix: fixed timestamps being timezone sensitive admin: due to this bug some logs may have been timestamped incorrectly /:cl: Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com>
## About The Pull Request Wiki is currently down but this should work once it's back. If you're on 516 or above it will open the page in-game, if you're still on 515 then it'll do the old behavior from the PR linked in the why it's good for the game section. ## Why It's Good For The Game In tgstation#86891 this was removed "Until 516 with webview2 releases", well it's here now so we're fvckin back ## Changelog :cl: qol: The wiki books for users on 516 no longer opens the page on an external website on your browser. /:cl:
## About The Pull Request Prevents users from passing bad data. ## Changelog :cl: fix: Fixed missing HTML encodes in comms console code /:cl:
## About The Pull Request Reverts tgstation#83361 ## Why It's Good For The Game I PR'd the original with the intent of making disease battling more engaging by adding warnings and sneeze dodging, but this was rejected and instead we got a very awkward middle ground where no one is happy and the original PR didnt accomplish what it set out to accomplish. You can't dodge the sneeze because it's a shotgun spread and invisible :/. The sneeze catchers are even somewhat buggy and the sneeze warning leads to extra chat clutter
## About The Pull Request Closes tgstation#89410 ## Changelog :cl: fix: Fixed wooden rifle stock being uncraftable /:cl:
|
carpotoxin my hero |
## About The Pull Request Closes tgstation#89037 color goes through KEEP_APART ## Changelog :cl: fix: Fixed exceptionally dark armrests on chairs /:cl:
## About The Pull Request Closes tgstation#89179 As a side effect, they also cover the id card sprite on your body but that shouldn't be too much of a concern ## Changelog :cl: fix: Fixed dress and gown rendering below gloves and shoes /:cl:
## About The Pull Request Puts Northstar's shuttles and docks back into the code. This allows for Northstar to be loaded by admins. ## Why It's Good For The Game Per Maurukas, shuttles should stay in the code.   ## Changelog Nothing player facing.
## About The Pull Request Removes `box/material`, and instead turns it into `bag/debug`. Replaces the box in the debug toolkit box, and places a bag in the little science room of runtimestation. ## Why It's Good For The Game Manually putting sheets into runtimestation's ore silo--or having to spawn in a sheet snatcher to do it for me--is really annoying, Now instead we can just pick up the bag and shove it in and be done with it. ## Changelog Not player facing
## About The Pull Request Fixes this  And fixes a runtime  ## Why It's Good For The Game People can recognize the detective beacuse of this, so i wanted to fix it Fixes are goooood!! ## Changelog :cl: Rengan fix: When you cast examine to the disguised detective, its assignment will now display correctly. /:cl:
## About The Pull Request 4 variations of drop and pickup, applied to bedsheets, pillows, bandages, regen meshes, surgical drapes. We had a cloth drop/pickup sound but I didn't think it fit the stuff I was applying it to so I made new ones, the old ones are still in just renamed to cloth_...1.ogg https://github.com/user-attachments/assets/60575f1e-56fd-489b-b363-49abd146cece ## Changelog :cl: grungussuss sound: new sounds for cloth items /:cl:
## About The Pull Request Changes 5/10mil * 1/3 chance for helbitaljanken, to 5/100k *1/3 chance for helbitaljanken ## Why It's Good For The Game Helbitaljanken requires a lot more prep then pulse rifle while being 10 times rarer + 1/3 chance to even win, most of the time requires a friend to heal you if you die, or to damage you. You cant really survive in crit forever, some setups may come close to it. This is still extremely rare, and requires good setup and/or a friend. Wiki also has wrong info on the reaper chance, for some reason. ## Changelog :cl: balance: Helbital reaper is now 100x more likely.
## About The Pull Request the comment lies, the skin var is no longer null safe medibots crafted with a non-special medkit would give it a null skin, which is no longer supported after they were reskinned ## Why It's Good For The Game 👻 ## Changelog :cl: fix: crafted medibots are more consistently corporeal /:cl:
Nerev4r
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This one was painful.
Why It's Good For The Game
Changelog
🆑
add: Added new mechanics or gameplay changes
add: Added more things
del: Removed old things
qol: made something easier to use
balance: rebalanced something
fix: fixed a few things
sound: added/modified/removed audio or sound effects
image: added/modified/removed some icons or images
map: added/modified/removed map content
spellcheck: fixed a few typos
code: changed some code
refactor: refactored some code
config: changed some config setting
admin: messed with admin stuff
server: something server ops should know
/:cl: