fixed address range typo #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a typo in the Bank 1 read range from 0xC000 to 0xD000
|
Awesome, thanks! |
|
yeah, this has actually been a really good learning experience for me. It
feels really cool to contribute, even if it's a single typo.
…On Thu, Oct 17, 2019, 11:05 PM Declan Hopkins ***@***.***> wrote:
Awesome, thanks!
Was pleasantly surprised to see a PR for this project :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#110?email_source=notifications&email_token=AGBSPUAVZRYBYTGX7CWPEP3QPERXTA5CNFSM4JCB4HUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBSKUOI#issuecomment-543468089>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGBSPUCCQINGWQM35R2CWB3QPERXTANCNFSM4JCB4HUA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ReadByte and WriteByte functions (MMU.cpp), the addressable range of Bank 1 should be 0xD000 to 0xDFFF.