Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain verification configuration for S4E platform #589

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

hatice-s4e
Copy link

Description

Added the domain verification template for S4E to include a unique verification text for each domain. This addition ensures that each domain receives a distinct verification code during the setup process.

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

Example variable values

domain: example.com
host: @
verify_text: 2390fdacda61c067f81dd8e4dababf9c
"testData": {
  "s4e-test": {
    "variables": {
      "domain": "example.com",
      "host": "@",
      "verify_text": "2390fdacda61c067f81dd8e4dababf9c"
    },
    "results": [
      {
        "type": "TXT",
        "name": "@",
        "ttl": 3600,
        "data": "\"s4e-site-verification=2390fdacda61c067f81dd8e4dababf9c\""
      }
    ]
  }
}

Copy link

Linter OK:

Linter result for s4e.io.domain-verification.json

@hatice-s4e hatice-s4e requested a review from pawel-kow February 28, 2025 12:57
Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pawel-kow pawel-kow added this pull request to the merge queue Feb 28, 2025
Merged via the queue into Domain-Connect:master with commit 70831b5 Feb 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants