Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creat phantom.cname-record.json & gophantom.io.site-a-record.json #587

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

JessSamis
Copy link

@JessSamis JessSamis commented Feb 24, 2025

Description

<-- short description of the template(s) and/or reason for update -->

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

Example variable values

<-- to make review process easier please provide example set of variable values for this template -->
CNAME:
"testData": {
"out.testtemplate.com": {
"variables": {
"domain": "gophantom.io",
"host": "domainconnect",
"cnameValue": "in.saascustomdomains.com"
},
"results": [
{
"type": "CNAME",
"name": "www.domainconnect",
"ttl": 3600,
"data": "in.saascustomdomains.com"
}
]
}
}

A:
"testData": {
"testData": {
"variables": {
"domain": "gophantom.io",
"host": "domainconnect",
"IP1": "34.68.234.4"
},
"results": [
{
"type": "A",
"name": "domainconnect",
"ttl": 600,
"data": "34.68.234.4"
}
]
}
}

A & CNAME :
"testData": {
"a&cname": {
"variables": {
"domain": "example.com",
"host": "domainconnect",
"IP1": "34.68.234.4",
"cnameValue": "in.saascustomdomains.com"
},
"results": [
{
"type": "A",
"name": "domainconnect",
"ttl": 600,
"data": "34.68.234.4"
},
{
"type": "CNAME",
"name": "www.domainconnect",
"ttl": 3600,
"data": "in.saascustomdomains.com"
}
]
}
}

Copy link

github-actions bot commented Feb 24, 2025

Linter OK:

Linter result for gophantom.io.cname-record.json
Linter result for gophantom.io.site-a-cname-record.json
Linter result for gophantom.io.site-a-record.json

@JessSamis JessSamis changed the title Create cname-record phantom.cname-record Feb 24, 2025
@JessSamis JessSamis changed the title phantom.cname-record Creat phantom.cname-record.json Feb 24, 2025
Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out the pull request template properly.

@kerolasa
Copy link
Collaborator

Rather strange, the dc-template-linter did not complain file name is cname-record and not gophantom.io.cname-record.json in 728380f. I suppose the github action that selects which files need to be checked has a scoping bug.

@pawel-kow
Copy link
Member

Rather strange, the dc-template-linter did not complain file name is cname-record and not gophantom.io.cname-record.json in 728380f. I suppose the github action that selects which files need to be checked has a scoping bug.

Oh... that's indeed interesting but should not be a big issue since the second GH action should catch this. It was basically not executed due to new contributor policy. I let it run now and let's see.

@pawel-kow
Copy link
Member

@kerolasa ok, now I see. The file is not even having JSON extension...
That's why both GH actions skipped it.
@JessSamis please fix the file naming and again pls fill in the PR template properly.

@JessSamis JessSamis requested a review from pawel-kow February 26, 2025 18:47
@JessSamis JessSamis changed the title Creat phantom.cname-record.json Creat phantom.cname-record.json & gophantom.io.site-a-record.json Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants