-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creat phantom.cname-record.json & gophantom.io.site-a-record.json #587
base: master
Are you sure you want to change the base?
Conversation
Linter OK:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill out the pull request template properly.
Rather strange, the dc-template-linter did not complain file name is |
Oh... that's indeed interesting but should not be a big issue since the second GH action should catch this. It was basically not executed due to new contributor policy. I let it run now and let's see. |
@kerolasa ok, now I see. The file is not even having JSON extension... |
Description
<-- short description of the template(s) and/or reason for update -->
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.json
Example variable values
<-- to make review process easier please provide example set of variable values for this template -->
CNAME:
"testData": {
"out.testtemplate.com": {
"variables": {
"domain": "gophantom.io",
"host": "domainconnect",
"cnameValue": "in.saascustomdomains.com"
},
"results": [
{
"type": "CNAME",
"name": "www.domainconnect",
"ttl": 3600,
"data": "in.saascustomdomains.com"
}
]
}
}
A:
"testData": {
"testData": {
"variables": {
"domain": "gophantom.io",
"host": "domainconnect",
"IP1": "34.68.234.4"
},
"results": [
{
"type": "A",
"name": "domainconnect",
"ttl": 600,
"data": "34.68.234.4"
}
]
}
}
A & CNAME :
"testData": {
"a&cname": {
"variables": {
"domain": "example.com",
"host": "domainconnect",
"IP1": "34.68.234.4",
"cnameValue": "in.saascustomdomains.com"
},
"results": [
{
"type": "A",
"name": "domainconnect",
"ttl": 600,
"data": "34.68.234.4"
},
{
"type": "CNAME",
"name": "www.domainconnect",
"ttl": 3600,
"data": "in.saascustomdomains.com"
}
]
}
}