FIX: All contacts were loaded even if no thirdparty was selected #31877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ($searchSocid <= 0 && getDolGlobalString('MAIN_ACTIONCOM_CAN_ADD_ANY_CONTACT')) { | ||
| $searchSocid = 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
You have redondancy with your multiple if statements, you can simplify with
$searchSocid = ($object->socid > 0) ? $object->socid : (getDolGlobalString('MAIN_ACTIONCOM_CAN_ADD_ANY_CONTACT') ? 0 : -1);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is only problematic with a huge amount of contacts.
It only append on an existing actioncomm with no contact or thirdparty attributed. When the user chose to modify it, all the contacts were loaded into the contact selector, resulting in a very slow-loading or even broken page.
I decided to do as it is now on actioncomm creation: the thirdparty needs to be selected before contact.
This behavior can be deactivated with conf
MAIN_ACTIONCOM_CAN_ADD_ANY_CONTACT