FIX: box_actions.php still uses fk_user_done which no longer exists #31190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX
I installed a brand new Dolibarr 20.0 and created an account with read permission on events, but not on other people's events. When I logged on with this user, I got SQL errors for the boxes
I found that, only for unprivileged users, the column
fk_user_doneis still used in some queries. This column was removed in v14.0, hence the error.Important note
I am fixing it in v14.0 because this column was removed in this release, but in 14.0, the box
box_actions_future.phpdidn't exist and, in v20.0, that box too referencesfk_user_done(and maybe in a few older versions as well), so it should also be fixed there.