FIX - Update Accounting closure with missing too many A-Nouveau #30039
Conversation
FIX The aim of this fix is to make sure we generate all the A-Nouveaux with an Update bookkeeping.class.php code If we limit the duplicates analysis to limited variables (actual situation) then in some cases we failed in generating all the A-nouveaux. With the following fix in one customer case, we went from 150 lines to more than 2000. This fix used 3 more variables : montant - compte tiers - label compte tiers Note that we must include then 'doc_type - fk_doc - numero_compte - label - montant - compte tiers - label compte tiers' to be sure to have unicity of line (because we may have several lines identical)
|
Hi @josett225 , With "amount", we have all the lines from the previous year. This may be an option, but it wasn't the original intention. The aim was to group the amounts of customer or supplier invoices under a single amount, not detailed so as to be able to letter. |
| @@ -341,6 +342,9 @@ public function create(User $user, $notrigger = false) | |||
| } | |||
| $sql .= " AND numero_compte = '".$this->db->escape($this->numero_compte)."'"; | |||
| $sql .= " AND label_operation = '".$this->db->escape($this->label_operation)."'"; | |||
| $sql .= " AND montant = '".((float) $this->montant)."'"; | |||
There was a problem hiding this comment.
If you introduce this lines, it means you want to remove the protection.
Without the protection, it will be possible to have duplicate line with same
doc_type, doc id, entity, account number and account label
This protection is not very good because we should have a protection on
doc_type, doc id, entity, account number. But it is better than nothing.
I don't see the use cases when we need to have duplicates on this 4 fields. Can you provide an example of values for this 4 parameters and the use case that explain why we need to be able to insert such duplicate ?
There was a problem hiding this comment.
@eldy You were right
|
Hi @eldy and @aspangaro FYI this has been refused by 2 accounting experts for now. |
|
Hi @eldy and @aspangaro I suggest we could add either an option in Setup Other or in the accounting admin to activate the A-nouveau detail feature. Thoughts? |
@josett225 Yes, please add your new behaviour as an option (first step as a hidden option with no setup page). so it is easier to analyse the change the option has into code for impact analysis. Also, can you answer this: I don't see the use cases when we need to have duplicates on this 4 fields. Can you provide an example of values (at least 2 lines) for this 4 parameters and the use case that explain why we need to be able to insert such duplicate ? |
|
Hi @eldy |
|
Hi, by any chance, are you still working on this ? @josett225 |
|
Hi @alexandre-janniaux |
|
Hi, that's incredible, great! I can finish adding the bookeeping test infrastructure so that I can help you integrate this. I'm running 19.0.3 currently, will upgrade to 19.0.4 after I get some time for more testing, but I can adapt. |
There was a problem hiding this comment.
Hi @eldy, @alexandre-janniaux and @aspangaro
After deep investigation, I found out that I was wrong in including all the values to find duplicates.
The issue I was facing on getting duplicates was coming from the database not be clean enough due to changes happening during the company journey in account labels or sub_account labels and when trying do a closure to generate a-nouveaux. Another PR is coming in a few minutes to clean the closure code.
However it is important to add the subledger_account to find duplicates when required.
FIX I did further testing and investigation and I fixed the following issues that stop doing a full closure without duplicate lines generated by an unclean database :
- different label_compte with same account number
- removing label_compte is raising an issue and the code in the line around 2770 $bookkeeping->label_compte = $obj->label_compte;
- different subledger_label with same subledger_account
- empty versus null values for subledger_label and subledger_account
- opening_balance is 0 as it creates a bookkeeping entry for now.
FIX - Update Accounting closure with missing too many A-Nouveau Dolibarr#30039)
This will help to better and understand and follow this fix
|
As agreed with @eldy, I close this PR. Code has been moved to another PR |
FIX The aim of this fix is to make sure we generate all the A-Nouveaux with an Update of bookkeeping.class.php code
If we limit the duplicates analysis to limited variables (actual situation) then in some cases with large bookkeeping lines we failed in generating all the A-nouveaux.
With the following fix in one customer case, we went from 150 lines to more than 2000. This fix used 3 more variables :
montant - compte tiers - label compte tiers or in SQL wording
montant - subledger_account - subledger_label
New Comment : Note that we must include then 'doc_type - fk_doc - numero_compte - label - montant - compte tiers - label compte tiers' to be sure to have unicity of line (because we may have several lines identical)