Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Various payment - Use list of account when edit #27992

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

aspangaro
Copy link
Member

When we edit accounting account in various payment card, it's a simple input. Possible to define an account who doesn't exist in chart of account. Modify to show list.

Before:

302082551-38c6e125-7423-4a6b-992e-8afad8fef7f0

After:

image

image

@eldy
Copy link
Member

eldy commented Feb 5, 2024

We already have this option ACCOUNTANCY_COMBO_FOR_AUX in accountancy setup:
image

So we should reuse the same option to define if auxiliary account must use a combo list or not, like done on the filter on auxiliary account into bookeepinglist.php.

@eldy eldy added the PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) label Feb 5, 2024
@aspangaro
Copy link
Member Author

Hello @eldy

I'm taking this option into consideration on line 677 of the accounting/bank/various_payment/card.php file in order to revert to a simple input if the user chooses not to use a sub-account selection list.

Do you want me to change anything else, I don't understand your request?

@eldy
Copy link
Member

eldy commented Feb 5, 2024

Hello @eldy

I'm taking this option into consideration on line 677 of the accounting/bank/various_payment/card.php file in order to revert to a simple input if the user chooses not to use a sub-account selection list.

Do you want me to change anything else, I don't understand your request?

I just did not found the if. Was looking for getDolGlobalString. Can you just replace the
if (!empty($conf->global->ACCOUNTANCY_COMBO_FOR_AUX)) {
with
if (getDolGlobalString('ACCOUNTANCY_COMBO_FOR_AUX')) {
The old syntax with conf->global->xxx must be abandonned;

@aspangaro
Copy link
Member Author

Correction done. Sorry, bad habit.

@aspangaro aspangaro removed the PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) label Feb 5, 2024
@eldy eldy merged commit 1747a2f into Dolibarr:develop Feb 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants