Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW: add column to store a label for the price #27238

Merged
merged 6 commits into from
Jan 11, 2024
Merged

NEW: add column to store a label for the price #27238

merged 6 commits into from
Jan 11, 2024

Conversation

FHenry
Copy link
Member

@FHenry FHenry commented Dec 28, 2023 •
edited
Loading

fix #27237

@FHenry FHenry changed the title NEW: add column to store a label for the price (#27237) NEW: add column to store a label for the price Dec 28, 2023
@lmag lmag requested a review from eldy December 28, 2023 11:48
@eldy
Copy link
Member

eldy commented Dec 28, 2023

Can you create migration file 19 to 20 instead of 18 to 19 ?

@eldy eldy added PR postponed PR is postponed (will be processed later). Ie: feature pushed during a beta or need transition steps PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) labels Dec 28, 2023
@FHenry FHenry force-pushed the dev_add_comment_on_price_log_BDD branch from c3d35ce to e8a850f Compare January 8, 2024 20:13
@FHenry
Copy link
Member Author

FHenry commented Jan 8, 2024

Can you create migration file 19 to 20 instead of 18 to 19 ?

@eldy Done

@eldy
Copy link
Member

eldy commented Jan 8, 2024

Got conflict due to another pr merged. Github conflict tool refuse to allow me to fix this. Can you do it on your side?

@eldy eldy merged commit f00c80f into Dolibarr:develop Jan 11, 2024
2 checks passed
@FHenry FHenry deleted the dev_add_comment_on_price_log_BDD branch January 12, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmag lmag lmag approved these changes

@eldy eldy Awaiting requested review from eldy

Assignees
No one assigned
Labels
PR postponed PR is postponed (will be processed later). Ie: feature pushed during a beta or need transition steps PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add comment on change price for products and services
3 participants
@FHenry @eldy @lmag