Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW : Add custom Text on footer total #26334

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

defrance
Copy link
Contributor

This function allows you to add a small text to each invoice below the total. Just add a miscellaneous parameter to activate it
(to wish the happy new year or an indication of invoicing)

Instructions

This is a template to help you make good pull requests. You may use Github Markdown syntax to format your issue report.
Please:

  • only keep the "FIX", "CLOSE" or "NEW" section (use uppercase to have the PR appears into the ChangeLog, lowercase will not appears)
  • follow the project contributing guidelines
  • replace the bracket enclosed texts with meaningful information

FIX|Fix #[issue_number Short description]

[Long description]

CLOSE|Close #[issue_number Short description]

[Long description]

NEW|New [Short description]

[Long description]

This function allows you to add a small text to each invoice below the total.
Just add a miscellaneous parameter to activate it
(to wish the happy new year or an indication of invoicing)
@@ -1646,6 +1647,14 @@ protected function _tableau_tot(&$pdf, $object, $deja_regle, $posy, $outputlangs
}

$index++;

if (!empty($conf->global->BILL_TEXT_TOTAL_FOOTER)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use now getDolGlobalString('...') instead of conf->global->...

@eldy eldy added the PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) label Oct 23, 2023
Copy link
Contributor Author

@defrance defrance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKI change made

@eldy eldy merged commit 091d50e into Dolibarr:develop Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants