Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW : Factoring and Fix external module elementType limit #21674

Closed
wants to merge 39 commits into from
Closed

NEW : Factoring and Fix external module elementType limit #21674

wants to merge 39 commits into from

Conversation

john-botella
Copy link
Member

@john-botella john-botella commented Aug 5, 2022 •
edited
Loading

FIX

Module builder or external module element type 32 char limitation

NEW

Factoring element_element fetch object mechanism to be used in more conditions

create new statics methods

  • getElementType
  • extractElementTypeInfosFromString
  • getObjectByElementType
  • getObjectFromCache

Add new class ElementProperties to allow developers to define elements properties for old modules or class override ;-)

@atm-florianm
Update htdocs/install/mysql/tables/llx_element_type.sql
ba33594 
Co-authored-by: Florian Mortgat <50440633+atm-florianm@users.noreply.github.com>
ATM john added 3 commits September 1, 2022 10:24
@john-botella john-botella changed the title NEW/FIX : Factoring and Fix external module elementType limit NEW : Factoring and Fix external module elementType limit Sep 1, 2022
@john-botella john-botella requested a review from eldy September 12, 2022 13:23
@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Sep 12, 2022
@john-botella john-botella changed the title NEW : Factoring and Fix external module elementType limit DRAFT : NEW : Factoring and Fix external module elementType limit Oct 24, 2022
@john-botella john-botella marked this pull request as draft October 24, 2022 15:42
@john-botella john-botella changed the title DRAFT : NEW : Factoring and Fix external module elementType limit NEW : Factoring and Fix external module elementType limit Oct 26, 2022
@john-botella john-botella marked this pull request as ready for review October 26, 2022 07:29
@john-botella john-botella requested a review from eldy October 26, 2022 07:30
@john-botella
Copy link
Member Author

So ?

@john-botella
Copy link
Member Author

@eldy ?

@eldy
Copy link
Member

eldy commented Oct 4, 2023 •
edited
Loading

Sorry John, can you help me to fix conflict ?
Also i have changes into .sql file of migration. Is it done on purpose or this remains from an other PR ?

@eldy eldy added PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) and removed Discussion Some questions or discussions are opened and wait answers of author or other people to be processed labels Oct 4, 2023
@eldy
Copy link
Member

eldy commented Jan 10, 2024

@atm-john can you help me to fix conflict ?

@john-botella
Copy link
Member Author

john-botella commented Mar 5, 2024 •
edited
Loading

I'll make a new FIX but with several pull requests.
Don't close, I'll do it after the pull requests are created.

This was referenced Mar 6, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atm-florianm atm-florianm atm-florianm left review comments

@eldy eldy Awaiting requested review from eldy

Assignees
No one assigned
Labels
PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-botella @eldy @atm-florianm