FIX searchèuser filter expedition list #14290 #15900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Jan 6, 2021
eldy
reviewed
Jan 30, 2021
| if ($search_user > 0) | ||
| { | ||
| $sql .= ", ".MAIN_DB_PREFIX."element_contact as ec"; | ||
| $sql .= ", ".MAIN_DB_PREFIX."c_type_contact as tc"; | ||
| $sql .= " INNER JOIN ".MAIN_DB_PREFIX."element_contact as ec ON u.rowid = ec.element_id"; |
There was a problem hiding this comment.
The table u is the table to get name of the user fk_user_author.
But the search on user is to find object linked with element_id so we need a link between
ec.element_id and e.rowid linked to id of object (but for shipment the id of object is not the shipment id but order id so we have to make a second linkt to element_element to find order id.
I submitted a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.