Alternate fix for doPoll timer spam at startup #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it and it works. |
Polling requires an API key so there's no point running it without one. The function that obtains said key ensures polling is started, so any other attempt at polling without a key (such as a tradeOffers or newItems event at startup) can be safely treated as a race condition and ignored. This re-uses the shutdown race condition bailout by simply treating the "key not yet set" state the same as the "key no longer set" state.
|
Force-pushed new commits, now based on top of @Aareksio's fix after double-checking what was going on. Basically:
|
Aareksio
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polling requires an API key so there's no point running it without one. The
function that obtains said key ensures polling is started, so any other attempt
at polling without a key (such as a tradeOffers or newItems event at startup)
can be safely treated as a race condition and ignored. This re-uses the shutdown
race condition bailout by simply treating the "key not yet set" state the same
as the "key no longer set" state.
Fixes #236 #237.