Assign Quantity to Specific Weapons

DnDGen · Aug 8, 2023 · 215f27b · 215f27b
1 parent 95d7002
commit 215f27b
Show file tree

Hide file tree

Showing 6 changed files with 197 additions and 5 deletions.
diff --git a/DnDGen.TreasureGen.Tests.Integration/Generators/Items/ItemPowerTestData.cs b/DnDGen.TreasureGen.Tests.Integration/Generators/Items/ItemPowerTestData.cs
@@ -31,6 +31,22 @@ public static IEnumerable Armors
             }
         }
 
+        public static IEnumerable SpecificArmors
+        {
+            get
+            {
+                var armors = ArmorConstants.GetAllSpecificArmorsAndShields();
+
+                foreach (var armor in armors)
+                {
+                    foreach (var power in powers)
+                    {
+                        yield return new TestCaseData(armor, power);
+                    }
+                }
+            }
+        }
+
         public static IEnumerable Potions
         {
             get
@@ -111,6 +127,22 @@ public static IEnumerable Weapons
             }
         }
 
+        public static IEnumerable SpecificWeapons
+        {
+            get
+            {
+                var weapons = WeaponConstants.GetAllSpecific();
+
+                foreach (var weapon in weapons)
+                {
+                    foreach (var power in powers)
+                    {
+                        yield return new TestCaseData(weapon, power);
+                    }
+                }
+            }
+        }
+
         public static IEnumerable WondrousItems
         {
             get

diff --git a/DnDGen.TreasureGen.Tests.Integration/Generators/Items/Magical/MagicalArmorGeneratorTests.cs b/DnDGen.TreasureGen.Tests.Integration/Generators/Items/Magical/MagicalArmorGeneratorTests.cs
@@ -53,6 +53,7 @@ public void GenerateArmorOfSize(string itemName, string power, string size)
             var item = ArmorGenerator.Generate(power, itemName, "my trait", size);
             itemVerifier.AssertItem(item);
             Assert.That(item, Is.InstanceOf<Armor>());
+            Assert.That(item.Quantity, Is.EqualTo(1));
 
             var armor = item as Armor;
             Assert.That(armor.ItemType, Is.EqualTo(ItemTypeConstants.Armor), $"{armor.Name} {armor.Magic.Curse}");
@@ -88,6 +89,7 @@ public void GenerateShieldOfSize(string itemName, string power, string size)
             var item = ArmorGenerator.Generate(power, itemName, "my trait", size);
             itemVerifier.AssertItem(item);
             Assert.That(item, Is.InstanceOf<Armor>());
+            Assert.That(item.Quantity, Is.EqualTo(1));
 
             var armor = item as Armor;
             Assert.That(armor.ItemType, Is.EqualTo(ItemTypeConstants.Armor), $"{armor.Name} {armor.Magic.Curse}");
@@ -109,5 +111,14 @@ public void BUG_DragonhideCastersShieldRemovesWoodAndMetalAsAttributes(string po
             Assert.That(shield.Attributes, Does.Not.Contain(AttributeConstants.Wood)
                 .And.Not.Contain(AttributeConstants.Metal));
         }
+
+        [TestCaseSource(typeof(ItemPowerTestData), nameof(ItemPowerTestData.SpecificArmors))]
+        public void BUG_GenerateArmor_SpecificArmorHasQuantity(string itemName, string power)
+        {
+            var item = ArmorGenerator.Generate(power, itemName);
+            itemVerifier.AssertItem(item);
+            Assert.That(item, Is.InstanceOf<Armor>(), item.Name);
+            Assert.That(item.Quantity, Is.EqualTo(1), item.Name);
+        }
     }
 }
diff --git a/DnDGen.TreasureGen.Tests.Integration/Generators/Items/Magical/MagicalWeaponGeneratorTests.cs b/DnDGen.TreasureGen.Tests.Integration/Generators/Items/Magical/MagicalWeaponGeneratorTests.cs
@@ -185,5 +185,14 @@ public void GenerateSpecificMagicalWeaponWithExtraDamage(string weaponName)
             Assert.That(weapon.Damages, Has.Count.GreaterThan(1), weapon.DamageDescription);
             Assert.That(weapon.CriticalDamages, Has.Count.GreaterThan(1), weapon.CriticalDamageDescription);
         }
+
+        [TestCaseSource(typeof(ItemPowerTestData), nameof(ItemPowerTestData.SpecificWeapons))]
+        public void BUG_GenerateWeapon_SpecificWeaponHasQuantity(string itemName, string power)
+        {
+            var item = WeaponGenerator.Generate(power, itemName);
+            itemVerifier.AssertItem(item);
+            Assert.That(item, Is.InstanceOf<Weapon>(), item.Name);
+            Assert.That(item.Quantity, Is.AtLeast(1), item.Name);
+        }
     }
 }
diff --git a/DnDGen.TreasureGen.Tests.Unit/Generators/Items/ItemVerifier.cs b/DnDGen.TreasureGen.Tests.Unit/Generators/Items/ItemVerifier.cs
@@ -20,6 +20,7 @@ public ItemVerifier()
         public void AssertItem(Item item)
         {
             Assert.That(item.Name, Is.Not.Empty);
+            Assert.That(item.Quantity, Is.Positive, item.Description);
             Assert.That(item.ItemType, Is.Not.Empty, $"{item.Description} item type");
             Assert.That(item.BaseNames, Is.Not.Empty, item.Description);
             Assert.That(item.BaseNames, Is.All.Not.Empty, item.Description);