Ported to canvaskit-wasm@0.36.1 #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DjDeveloperr Any updates on getting this merged? Should I write more tests? |
|
Sorry for delay, I'll try to review it ASAP 😅 |
|
This PR is out of date, closing and will open a new one when I have time. canvaskit-wasm@0.37.0 got released relatively recently so I'll base it off of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bit of reverse engineering (using mostly https://www.diffchecker.com), I ported Deno-canvas to canvaskit-wasm@0.36.1.
I have successfully run the three examples in the repo but I think the medium to short term plan is to add concrete tests.
I don't think this could be a breaking change, but I'm not 100% certain sure.
This closes #28.