Resolve Entity Interface types #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzlsakal
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Thank you for the PR @TannerRogalsky! Apart from the formatting check in the CI, I left a small comment for a function. Nice work!
Co-authored-by: Doruk Gurleyen <dorukgurleyen@gmail.com>
kzlsakal
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apollo Federation v2.3 introduced new @interfaceObject directive that allows users to extend entity functionality through inheritance. This allows entities to be interfaces (with some contraints). This PR addresses two issues:
@keydirective, it should not be include in the_Entityunion in the SDL.resolve_typefor the interface type should result in materialized fields for correctly configured interfaces.Thank you!