Merge to my master kliment#1054 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Color settings were copied from PronterWindow.settings to PronterWindow before reading them from config file into PronterWindow.settings.
Now settings except 3D view move colors (e.g. gcview_color_background) are applied without restart
Reset was not detected for applying because it set both widget value and setting value. Removed confirmation message box for each reset setting and let the settings dialog OK button confirm as with normal changes
Use wxpython widget ColourPickerCtrl. Tested only on Ubuntu. Move validation callbacks from Settings.__...() to Setting.validate()
Extracted base class BaseViz to add structure, reuse code, and reduce hasattr()
It's a regression in my recent commit.
Used _ for a dummy int variable, and _('localization') broke.
Added logging where the exception was
silently ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kliment#1054