Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: init the test & add the tests of TutorialModal #61

Merged
merged 5 commits into from
Jan 3, 2021
Merged

test: init the test & add the tests of TutorialModal #61

merged 5 commits into from
Jan 3, 2021

Conversation

yeefun
Copy link
Contributor

@yeefun yeefun commented Dec 26, 2020 •
edited
Loading

  • 建置單元測試環境：
    • 使用測試框架 Jest 和函式庫 Testing Library。
    • 每次 commit 前都會跑過全部測試一遍，沒問題 commit 才會成功。
    • 為什麼測試函式庫不使用 @vue/test-utils？
      • 依之前在公司測試的經驗，如這篇所說，@vue/test-utils 提供的方法容易引導開發者去測試細節，以致日後難以重構程式碼。
      • 看完這篇文章，以及認同 Testing Library 的設計理念，決定嘗試看看 @testing-library。
  • 為 TutorialModal 元件新增測試。

@yeefun yeefun force-pushed the test/init branch 4 times, most recently from fe86ced to 5da6e7a Compare December 27, 2020 06:04
yoyo930021
yoyo930021 reviewed Dec 27, 2020
View reviewed changes
Copy link
Contributor

@yoyo930021 yoyo930021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我們是用 Github action
要不要把 unit test 加進去 CI ?

yoyo930021
yoyo930021 reviewed Dec 27, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@yeefun
Copy link
Contributor Author

yeefun commented Dec 27, 2020

#61 (review)
我們是用 Github action
要不要把 unit test 加進去 CI ?

ok，這是我第一次碰 Github Actions，我來研究看看怎麼用。

@yoyo930021
Copy link
Contributor

#61 (review)
我們是用 Github action
要不要把 unit test 加進去 CI ?

ok，這是我第一次碰 Github Actions，我來研究看看怎麼用。

基本上改這個檔案就可以了
https://github.com/Disfactory/frontend/blob/master/.github/workflows/ci.yml

@yeefun yeefun self-assigned this Jan 3, 2021
@yeefun yeefun merged commit 83e2810 into Disfactory:master Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo930021 yoyo930021 yoyo930021 left review comments

Assignees

@yeefun yeefun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeefun @yoyo930021