Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker deployment of the app #10

Merged

Conversation

benji011
Copy link
Contributor

@benji011 benji011 commented Oct 3, 2020

Purpose

Docker deployment of the flask-online-store app.

What

  • Added docker-compose.yaml for multi-container orchestration
  • Added Dockerfile for building the flask app
  • Added image for postgres
  • Removed pkg-resources==0.0.0 from requirements.txt (see additional notes)

Additional notes

I encountered this weird error when installing pkg-resources==0.0.0.

Error log
ERROR: Could not find a version that satisfies the requirement pkg-resources==0.0.0 (from -r requirements.txt (line 27)) (from versions: none)
ERROR: No matching distribution found for pkg-resources==0.0.0 (from -r requirements.txt (line 27))

I didn't know what it was but a quick google search told me it's just a bug resulting from Ubuntu providing wrong meta data to pip. I've removed it from requirements.txt for this reason but i can add it back if requested (Although this maybe kinda out of the scope of this PR).

refs: #2

@DiptoChakrabarty Please let me know if i've missed something or if there are any other issues. Thanks 👍

Dockerfile Outdated Show resolved Hide resolved
@benji011 benji011 changed the base branch from master to development October 4, 2020 00:27
@DiptoChakrabarty DiptoChakrabarty merged commit 35a8c5b into DiptoChakrabarty:development Oct 4, 2020
@DiptoChakrabarty
Copy link
Owner

Thanks for the changes , merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants