-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving flexbox behind a feature flag #414
Conversation
5522573
to
fe5164c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, I really like feature flagging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, but I have a few suggestions. Additionally conflicts with main
should be resolved (also clippy lints, but it looks like those have been fixed on main :))
fe5164c
to
3ab7ea7
Compare
3ab7ea7
to
a2e78f7
Compare
I've pushed a couple of changes:
|
Right! It's been a while and it's challenging to keep track of all the similar names 😅 |
Objective
Why did you make this PR?
Fix #298
Feedback wanted