Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up resources & entiteis after game ends #135

Closed
Tracked by #246
Indy2222 opened this issue Jun 18, 2022 · 0 comments
Closed
Tracked by #246

Clean-up resources & entiteis after game ends #135

Indy2222 opened this issue Jun 18, 2022 · 0 comments

Comments

@Indy2222
Copy link
Collaborator

Currently, majority of entities and resources inserted during game loading and game play are not removed after the game finishes. This is a memory leak and might lead to incorrect behavior during second game play.

@Indy2222 Indy2222 added this to the MVP milestone Jun 18, 2022
Indy2222 added a commit to Indy2222/de that referenced this issue Nov 5, 2022
AppState holds high level state of the whole application. InGameState
holds states once inside a game (loading, playing, ...).

This commit adds .run_in_state() condition to most systems which did not
have the condition already => only systems which must run outside the
game does.

This commit does NOT implement proper cleanup after a game
finishes (DigitalExtinction#135).

Relates to DigitalExtinction#34.
Indy2222 added a commit to Indy2222/de that referenced this issue Nov 5, 2022
AppState holds high level state of the whole application. InGameState
holds states once inside a game (loading, playing, ...).

This commit adds .run_in_state() condition to most systems which did not
have the condition already => only systems which must run outside the
game does.

This commit does NOT implement proper cleanup after a game
finishes (DigitalExtinction#135).

Relates to DigitalExtinction#34.
Indy2222 added a commit to Indy2222/de that referenced this issue Nov 5, 2022
AppState holds high level state of the whole application. InGameState
holds states once inside a game (loading, playing, ...).

This commit adds .run_in_state() condition to most systems which did not
have the condition already => only systems which must run outside the
game does.

This commit does NOT implement proper cleanup after a game
finishes (DigitalExtinction#135).

Relates to DigitalExtinction#34.
Indy2222 added a commit to Indy2222/de that referenced this issue Nov 5, 2022
AppState holds high level state of the whole application. InGameState
holds states once inside a game (loading, playing, ...).

This commit adds .run_in_state() condition to most systems which did not
have the condition already => only systems which must run outside the
game does.

This commit does NOT implement proper cleanup after a game
finishes (DigitalExtinction#135).

Relates to DigitalExtinction#34.
Indy2222 added a commit to Indy2222/de that referenced this issue Nov 5, 2022
AppState holds high level state of the whole application. InGameState
holds states once inside a game (loading, playing, ...).

This commit adds .run_in_state() condition to most systems which did not
have the condition already => only systems which must run outside the
game does.

This commit does NOT implement proper cleanup after a game
finishes (DigitalExtinction#135).

Relates to DigitalExtinction#34.
Indy2222 added a commit to Indy2222/de that referenced this issue Nov 5, 2022
AppState holds high level state of the whole application. InGameState
holds states once inside a game (loading, playing, ...).

This commit adds .run_in_state() condition to most systems which did not
have the condition already => only systems which must run outside the
game does.

This commit does NOT implement proper cleanup after a game
finishes (DigitalExtinction#135).

Relates to DigitalExtinction#34.
@Indy2222 Indy2222 mentioned this issue Nov 15, 2022
83 tasks
Indy2222 added a commit to Indy2222/de that referenced this issue Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant