-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: add the implemet of setparamtype at show, showddl, datasource, limit plan ; executor: add new case 'LogicalLimit' at Next() #62
Conversation
Signed-off-by: studiolee <1964773741@qq.com>
Signed-off-by: studiolee <1964773741@qq.com>
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
=========================================
Coverage ? 69.3867%
=========================================
Files ? 523
Lines ? 151049
Branches ? 0
=========================================
Hits ? 104808
Misses ? 36304
Partials ? 9937 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some ut ?
Signed-off-by: jk <51103574+pupillord@users.noreply.github.com>
add ut for setparamtype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Issue Number: close #28
Problem Summary
some interface have not be implemented,so some sql statement can't get parameter type。
What is changed and how it works?
Proposal: xxx
What's Changed:
New implement method 'setparamtype' at show ,showddl, datasource, limit plan
How it Works:
set the parameter type from the plan tree
Related changes
Check List
Tests
Side effects
Release note