Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add the implemet of setparamtype at show, showddl, datasource, limit plan ; executor: add new case 'LogicalLimit' at Next() #62

Closed

Conversation

leeraya
Copy link
Contributor

@leeraya leeraya commented Sep 9, 2021

What problem does this PR solve?

Issue Number: close #28

Problem Summary

some interface have not be implemented,so some sql statement can't get parameter type。

What is changed and how it works?

Proposal: xxx

What's Changed:

New implement method 'setparamtype' at show ,showddl, datasource, limit plan

How it Works:

set the parameter type from the plan tree

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

Signed-off-by: studiolee <1964773741@qq.com>
@CLAassistant
Copy link

CLAassistant commented Sep 9, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@8687857). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             main        #62   +/-   ##
=========================================
  Coverage        ?   69.3867%           
=========================================
  Files           ?        523           
  Lines           ?     151049           
  Branches        ?          0           
=========================================
  Hits            ?     104808           
  Misses          ?      36304           
  Partials        ?       9937           

Copy link

@AmoebaProtozoa AmoebaProtozoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pupillord pupillord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some ut ?

pupillord and others added 2 commits September 14, 2021 17:33
Signed-off-by: jk <51103574+pupillord@users.noreply.github.com>
Copy link
Contributor

@pupillord pupillord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pupillord pupillord enabled auto-merge (squash) September 15, 2021 06:57
@pupillord pupillord disabled auto-merge September 15, 2021 06:57
@pupillord pupillord closed this Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the interface method of PhysicalPlan and LogicalPlan: SetParamType()
5 participants