Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: make check #39

Merged
merged 5 commits into from
Aug 16, 2021
Merged

Makefile: make check #39

merged 5 commits into from
Aug 16, 2021

Conversation

AmoebaProtozoa
Copy link

What problem does this PR solve?

Issue Number: #36

What is changed and how it works?

What's Changed:

  • rewritten some ineffective assignments
  • go mod tidy
  • limit the static-check tool to an earlier version so it won't complain about os differences
  • make linter not check inside PG table definition

How it Works:

make check

Result

All TiDB code quality checker should be happy now, although errdoc still complaints about duplicate error-code, but this should be the expected behavior (Same result on TiDB 4.0)

Signed-off-by: David <davidyangad@gmail.com>
Signed-off-by: David <davidyangad@gmail.com>
Signed-off-by: David <davidyangad@gmail.com>
Signed-off-by: David <davidyangad@gmail.com>
Signed-off-by: David <davidyangad@gmail.com>
@AmoebaProtozoa AmoebaProtozoa requested a review from a team August 16, 2021 02:38
Copy link

@RogueJin RogueJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pupillord pupillord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pupillord pupillord merged commit 78cccf7 into DigitalChinaOpenSource:main Aug 16, 2021
@AmoebaProtozoa AmoebaProtozoa deleted the make_check branch August 16, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants