Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/filtered vtt cues #90

Merged
merged 2 commits into from
Apr 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "hls.js",
"version": "1.5.7",
"version": "1.5.8",
"license": "Apache-2.0",
"description": "JavaScript HLS client using MediaSourceExtension",
"homepage": "https://github.com/video-dev/hls.js",
Expand Down
22 changes: 21 additions & 1 deletion src/utils/texttrack-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,25 @@ export function sendAddTrackEvent(track: TextTrack, videoEl: HTMLMediaElement) {
videoEl.dispatchEvent(event);
}

function containsCue(track: TextTrack, cue: VTTCue) {
if (!track.cues) {
return false;
}

for (let i = 0; i < track.cues.length; i++) {
const cueInTextTrack = track.cues[i] as VTTCue;
if (
cueInTextTrack.startTime === cue.startTime &&
cueInTextTrack.endTime === cue.endTime &&
cueInTextTrack.text === cue.text
) {
return true;
}
}

return false;
}

export function addCueToTrack(track: TextTrack, cue: VTTCue) {
// Sometimes there are cue overlaps on segmented vtts so the same
// cue can appear more than once in different vtt files.
Expand All @@ -21,7 +40,8 @@ export function addCueToTrack(track: TextTrack, cue: VTTCue) {
if (mode === 'disabled') {
track.mode = 'hidden';
}
if (track.cues && !track.cues.getCueById(cue.id)) {

if (track.cues && !containsCue(track, cue)) {
try {
track.addCue(cue);
if (!track.cues.getCueById(cue.id)) {
Expand Down
Loading