Fix/md5 management #108
Merged
Fix/md5 management #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This is because we can only know the md5 *after* the upload has completed, and we must set meta at the time of the upload, so we were using the original file's md5 instead of the transferred file md5
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
=============================================
- Coverage 72.64% 58.78% -13.86%
- Complexity 338 370 +32
=============================================
Files 65 97 +32
Lines 1378 1912 +534
Branches 147 167 +20
=============================================
+ Hits 1001 1124 +123
- Misses 323 729 +406
- Partials 54 59 +5 ☔ View full report in Codecov by Sentry. |
brunocorreiaweb
previously approved these changes
Jun 5, 2024
styxtwo
reviewed
Jun 5, 2024
.../src/main/java/technology/dice/dicewhere/downloader/destination/local/LocalFileAcceptor.java
Show resolved
Hide resolved
...er-lib/src/main/java/technology/dice/dicewhere/downloader/destination/s3/S3FileAcceptor.java
Show resolved
Hide resolved
.../src/main/java/technology/dice/dicewhere/downloader/destination/local/LocalFileAcceptor.java
Show resolved
Hide resolved
ghost
previously approved these changes
Jun 5, 2024
styxtwo
previously approved these changes
Jun 5, 2024
styxtwo
previously approved these changes
Jul 8, 2024
brunocorreiaweb
previously approved these changes
Jul 8, 2024
brunocorreiaweb
previously approved these changes
Jul 8, 2024
lcardito
reviewed
Jul 8, 2024
...ere-downloader-lib/src/main/java/technology/dice/dicewhere/downloader/source/FileSource.java
Show resolved
Hide resolved
lcardito
reviewed
Jul 8, 2024
...er-lib/src/main/java/technology/dice/dicewhere/downloader/destination/s3/S3FileAcceptor.java
Show resolved
Hide resolved
assert on contents of the "latest" file
This reverts commit cb14328.
assert on contents of the "latest" file
…into fix/md5_management
wermajew
approved these changes
Jul 8, 2024
wermajew
reviewed
Jul 8, 2024
.../src/main/java/technology/dice/dicewhere/downloader/destination/local/LocalFileAcceptor.java
Show resolved
Hide resolved
wermajew
previously approved these changes
Jul 8, 2024
wermajew
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to:
1 - replace user defined metadata by S3's etag for md5 matching
2 - Improve md5 logging
3 - Reject the destination file if md5 mismatches