Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#775: Audit and make documentation for command EXPIREAT consistent #981

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

michael-nau
Copy link
Contributor

Fixes #775

@AshwinKul28 AshwinKul28 marked this pull request as ready for review October 7, 2024 12:22
@AshwinKul28
Copy link
Contributor

AshwinKul28 commented Oct 7, 2024

HI @michael-nau thanks for the changes, can you please add an error example (Invalid Usage) as well. Thanks

@AshwinKul28 AshwinKul28 self-requested a review October 7, 2024 12:25
@michael-nau
Copy link
Contributor Author

HI @michael-nau thanks for the changes, can you please add an error example (Invalid Usage) as well. Thanks

Hey @AshwinKul28 - should be all done now. Thanks :)

Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation fixes @michael-nau! Thanks for the reviews @AshwinKul28. LGTM

@JyotinderSingh JyotinderSingh changed the title Audit and make documentation for command EXPIREAT consistent #775: Audit and make documentation for command EXPIREAT consistent Oct 10, 2024
@JyotinderSingh JyotinderSingh merged commit d6f17bd into DiceDB:master Oct 10, 2024
1 check passed
sashpawar11 pushed a commit to sashpawar11/dice that referenced this pull request Oct 13, 2024
…stent (DiceDB#981)

Co-authored-by: Mike <michael.naughton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit and make documentation for command EXPIREAT consistent
3 participants