-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#749 fix: http json response to use json null #980
Conversation
349c68f
to
db8efb3
Compare
this pr handles "(nil)" by replacing it with actual json null and enhances http response struct build workflow is failed but test is passing when ran as ╰─➤ go test -v -race -count=1 --run TestType ./integration_tests/commands/http |
cc @lucifercr07 |
db8efb3
to
c3e6e65
Compare
@JyotinderSingh i would like to have your input on this little issue, please |
The TestCommandInfo tests are failing, do you think this could have been introduced by your changes? |
yes it is introduced by my changes, will fix sooner |
2a6ae2b
to
e1da706
Compare
nvm test cases fixed |
e1da706
to
63fd523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes @vinitparekh17! LGTM.
resolved #749 issue