Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#749 fix: http json response to use json null #980

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

vinitparekh17
Copy link
Contributor

resolved #749 issue

@vinitparekh17 vinitparekh17 marked this pull request as draft October 6, 2024 10:24
@vinitparekh17 vinitparekh17 force-pushed the http-res branch 2 times, most recently from 349c68f to db8efb3 Compare October 7, 2024 08:02
@vinitparekh17
Copy link
Contributor Author

vinitparekh17 commented Oct 7, 2024

this pr handles "(nil)" by replacing it with actual json null and enhances http response struct

build workflow is failed but test is passing when ran as

╰─➤  go test -v -race -count=1 --run TestType ./integration_tests/commands/http

@vinitparekh17 vinitparekh17 marked this pull request as ready for review October 7, 2024 08:12
@vinitparekh17
Copy link
Contributor Author

this pr handles "(nil)" by replacing it with actual json null and enhances http response struct

build workflow is failed but test is passing when ran as

╰─➤  go test -v -race -count=1 --run TestType ./integration_tests/commands/http

cc @lucifercr07

@vinitparekh17
Copy link
Contributor Author

this pr handles "(nil)" by replacing it with actual json null and enhances http response struct
build workflow is failed but test is passing when ran as

╰─➤  go test -v -race -count=1 --run TestType ./integration_tests/commands/http

@JyotinderSingh i would like to have your input on this little issue, please

@JyotinderSingh
Copy link
Collaborator

this pr handles "(nil)" by replacing it with actual json null and enhances http response struct

build workflow is failed but test is passing when ran as

╰─➤ go test -v -race -count=1 --run TestType ./integration_tests/commands/http

@JyotinderSingh i would like to have your input on this little issue, please

The TestCommandInfo tests are failing, do you think this could have been introduced by your changes?
Haven't seen this error happen before.

@vinitparekh17
Copy link
Contributor Author

go test -v -race -count=1 --run TestType ./integration_tests/commands/http

yes it is introduced by my changes, will fix sooner

@vinitparekh17
Copy link
Contributor Author

this pr handles "(nil)" by replacing it with actual json null and enhances http response struct

build workflow is failed but test is passing when ran as

╰─➤ go test -v -race -count=1 --run TestType ./integration_tests/commands/http

@JyotinderSingh i would like to have your input on this little issue, please

The TestCommandInfo tests are failing, do you think this could have been introduced by your changes? Haven't seen this error happen before.

nvm test cases fixed

@vinitparekh17 vinitparekh17 changed the title #749 fix: json response #749 fix: http json response Oct 8, 2024
Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes @vinitparekh17! LGTM.

@JyotinderSingh JyotinderSingh merged commit 4b3b8ac into DiceDB:master Oct 13, 2024
2 checks passed
@JyotinderSingh JyotinderSingh changed the title #749 fix: http json response #749 fix: http json response to use json null Oct 13, 2024
@vinitparekh17 vinitparekh17 deleted the http-res branch October 13, 2024 10:40
kakdeykaushik pushed a commit to kakdeykaushik/dice that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in cmd responses via http protocol
2 participants