Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#817: docs: improve consistency in RPOP documentation #926

Merged
merged 4 commits into from
Oct 5, 2024
Merged

#817: docs: improve consistency in RPOP documentation #926

merged 4 commits into from
Oct 5, 2024

Conversation

sahitmandapati
Copy link
Contributor

@sahitmandapati sahitmandapati commented Oct 2, 2024 •
edited by JyotinderSingh
Loading

Fixes #817

@sahitmandapati sahitmandapati mentioned this pull request Oct 2, 2024
Closed
apoorvyadav1111
apoorvyadav1111 requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, The doc looks good to me. I have question regarding the following line:
For blocking behavior, consider using BRPOP. in the notes section,

I could not find any command implemented in Dice as of now. Would it be okay to confirm on this and if this is indeed the case, remove this line for now.

@sahitmandapati
Copy link
Contributor Author

Yes, BRPOP. is indeed not implemented in Dice as of now. i have removed it

@sahitmandapati
Copy link
Contributor Author

sahitmandapati commented Oct 3, 2024 •
edited
Loading

Even i had the same doubt but i let it there as it was part of the initial RPOP.md thanks for pointing it out.

apoorvyadav1111
apoorvyadav1111 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the documentation. If you have any questions in the future, please feel welcome to discuss it in the discord community.

@JyotinderSingh
Copy link
Collaborator

Thanks for the contribution @sahitmandapati. Thanks for the reviews @apoorvyadav1111. LGTM

@JyotinderSingh JyotinderSingh changed the title docs: improve consistency in RPOP documentation #817: docs: improve consistency in RPOP documentation Oct 5, 2024
@JyotinderSingh JyotinderSingh merged commit df4071d into DiceDB:master Oct 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvyadav1111 apoorvyadav1111 apoorvyadav1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit and make documentation for command RPOP consistent
3 participants
@sahitmandapati @JyotinderSingh @apoorvyadav1111