Make keystat localized to store instance #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: soumya-codes <151079203+soumya-codes@users.noreply.github.com>
Comment on lines
-21
to
-29
| func RespINFO(args []string) []byte { | ||
| var info []byte // Initialize a byte slice to hold the keyspace info. | ||
| buf := bytes.NewBuffer(info) // Create a buffer for efficiently writing the response. | ||
| buf.WriteString("# Keyspace\r\n") // Write the header "# Keyspace" to indicate the section for keyspace stats. | ||
| for i := range dstore.KeyspaceStat { // Iterate through the KeyspaceStat map, which holds the number of keys per database. | ||
| fmt.Fprintf(buf, "db%d:keys=%d,expires=0,avg_ttl=0\r\n", i, dstore.KeyspaceStat[i]["keys"]) // Format the keyspace info for each database. | ||
| } | ||
| return clientio.Encode(buf.String(), false) // Encode the result into a Redis protocol-compliant format and return the encoded bytes. | ||
| } |
There was a problem hiding this comment.
Just for my understanding, do we not need this anymore?
There was a problem hiding this comment.
This should still be here. However, since this becomes a multi-shard command, maybe that's why he's removing it for now, is my guess.
There was a problem hiding this comment.
Yes, I had removed this as it is a multi-key command...
lucifercr07
approved these changes
Sep 29, 2024
lucifercr07
added a commit
to lucifercr07/dice
that referenced
this pull request
Sep 30, 2024
This reverts commit f7a2856.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we move to multi-threading we need to localize the keystats store from being global which is the case today.