Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#650: Implementation HMGET command #743

Merged
merged 9 commits into from
Oct 4, 2024
Merged

#650: Implementation HMGET command #743

merged 9 commits into from
Oct 4, 2024

Conversation

vishnuchandrashekar
Copy link
Contributor

Closes #650

@vishnuchandrashekar vishnuchandrashekar marked this pull request as ready for review September 26, 2024 19:20
apoorvyadav1111
apoorvyadav1111 reviewed Sep 28, 2024
View reviewed changes
Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the changes look good to me. Would it be okay for you to add a 3-4 line comment over the evalHMGET function describing general logic?
Thanks

Edit: Please confirm if #705 is a duplicate for this. If yes, would it be okay to close the PR stating a small comment? This will ensure it is not reviewed.

@vishnuchandrashekar vishnuchandrashekar mentioned this pull request Sep 28, 2024
Closed
@vishnuchandrashekar
Copy link
Contributor Author

Hi @apoorvyadav1111, I've added the comments. Let me know if those are fine.
Yes #705 is a duplicate, I've gone ahead and closed it.

apoorvyadav1111
apoorvyadav1111 requested changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good to me. I have left one minor comment. Please check

JyotinderSingh
JyotinderSingh requested changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes @vishnuchandrashekar. I have left a few comments.

@JyotinderSingh
Copy link
Collaborator

@vishnuchandrashekar The PR is almost ready, let's try to address the comments and get it submitted soon.

@vishnuchandrashekar
Copy link
Contributor Author

Hey @JyotinderSingh , I've updated the tests and the addressed the comments. Please have a look.

@lucifercr07 lucifercr07 changed the title Feature hmget #650: Implementation HMGET command Oct 4, 2024
@lucifercr07 lucifercr07 merged commit 4eaef20 into DiceDB:master Oct 4, 2024
2 checks passed
@vishnuchandrashekar vishnuchandrashekar deleted the feature-HMGET branch October 9, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JyotinderSingh JyotinderSingh JyotinderSingh requested changes

@apoorvyadav1111 apoorvyadav1111 apoorvyadav1111 requested changes

@lucifercr07 lucifercr07 lucifercr07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for command HMGET
4 participants
@vishnuchandrashekar @JyotinderSingh @lucifercr07 @apoorvyadav1111