Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLIENT GETNAME and SETNAME command #1275

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

CLIENT GETNAME and SETNAME command #1275

wants to merge 10 commits into from

Conversation

kakdeykaushik
Copy link
Contributor

Dice implementation of Redis's CLIENT GETNAME and CLIENT SETNAME commands.

@kakdeykaushik kakdeykaushik marked this pull request as draft November 12, 2024 14:53
@kakdeykaushik kakdeykaushik marked this pull request as ready for review November 13, 2024 17:54
@kakdeykaushik
Copy link
Contributor Author

failing test in CI is known issue and is being discussed on Discord.

@apoorvyadav1111
Copy link
Contributor

Please rebase with master and lets see if CI passes. We have added several fixes.

@kakdeykaushik
Copy link
Contributor Author

All checks have passed, please review

@JyotinderSingh
Copy link
Collaborator

@kakdeykaushik Thanks for working on this change. Since we have now deprecated the async server we may need to think of an approach to implement this on the multi-threaded server.

Would you be willing to modify this PR to accommodate that?

@kakdeykaushik
Copy link
Contributor Author

I'll modify this to accomodate multi-threaded server

@JyotinderSingh
Copy link
Collaborator

I'll modify this to accomodate multi-threaded server

Thank you @kakdeykaushik. If you get stuck while implementing this, feel free to reach out on discord.

@kakdeykaushik
Copy link
Contributor Author

hi @JyotinderSingh , please have a look at this at this comment (circular dependency) and add your suggestion. Work on this PR depends on PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvyadav1111 apoorvyadav1111 Awaiting requested review from apoorvyadav1111

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kakdeykaushik @apoorvyadav1111 @JyotinderSingh