Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#781: Audit QWATCH documentation for consistency #1122

Merged
merged 2 commits into from
Oct 20, 2024
Merged

#781: Audit QWATCH documentation for consistency #1122

merged 2 commits into from
Oct 20, 2024

Conversation

shashank-priyadarshi
Copy link
Contributor

@shashank-priyadarshi shashank-priyadarshi commented Oct 17, 2024 •
edited
Loading

Fixes QWATCH audit and doc update.

  • Refactor using SET Command docs as reference
  • Use $ for path demonstration instead of .

@shashank-priyadarshi
docs: update QWATCH docs per SET template
851a9d4 
Signed-off-by: Shashank Priyadarshi <shashank9163882019@gmail.com>
JyotinderSingh
JyotinderSingh requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these change, have left a few comments.

docs/src/content/docs/commands/QWATCH.md Show resolved Hide resolved
docs/src/content/docs/commands/QWATCH.md Show resolved Hide resolved
@shashank-priyadarshi
Copy link
Contributor Author

@JyotinderSingh went through the review comments. Can you please review and let me know if I still need to update the pull request!

@shashank-priyadarshi
Copy link
Contributor Author

@JyotinderSingh reverted the change to syntax example. Please let me know if further changes are required.

JyotinderSingh
JyotinderSingh approved these changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes, approved.

@JyotinderSingh JyotinderSingh changed the title Audit QWATCH documentation for consistency #781: Audit QWATCH documentation for consistency Oct 20, 2024
@JyotinderSingh JyotinderSingh merged commit 219f18c into DiceDB:master Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JyotinderSingh JyotinderSingh JyotinderSingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit and make documentation for command QWATCH consistent
2 participants
@shashank-priyadarshi @JyotinderSingh