#1101: Refactor evalAPPEND to handle leading zeros in value #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucifercr07 @JyotinderSingh pls review this it fixes #1101 |
JyotinderSingh
requested changes
Oct 16, 2024
|
@JyotinderSingh @lucifercr07 I have added both unit test and integration_test for above append case |
JyotinderSingh
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Awesome, thanks for the fixes and tests @shashi-sah2003! LGTM
kakdeykaushik
pushed a commit
to kakdeykaushik/dice
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1101
evalAPPEND function wasn't configured to handle the case with leading zeros and it is treating value "0043" as "43"
I have added that case to handle it properly and producing desired result as of redis