Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1008: Added Q.WATCH support to Websocket #1090

Merged
merged 33 commits into from
Oct 21, 2024
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
3ca4c51
updated parsing logic to support qwatch and qunwatch commands
psrvere Oct 14, 2024
0feea23
update websocket server logic to support qwatch and qunwatch
psrvere Oct 14, 2024
53bf950
added integration tests
psrvere Oct 14, 2024
a8c99fe
add qunwatch unit test
psrvere Oct 14, 2024
b833052
fixed linter warnings
psrvere Oct 14, 2024
be7132a
remove qunwatch code
psrvere Oct 14, 2024
b0ee3a6
keep qunwatch as unimplemented command
psrvere Oct 14, 2024
3bbf747
merged with master
psrvere Oct 14, 2024
edc7203
fixed comment
psrvere Oct 14, 2024
e39c9a0
debugging
psrvere Oct 15, 2024
4e6dbe9
minor fixes
psrvere Oct 15, 2024
1e91489
moved test port to a constant
psrvere Oct 15, 2024
7307273
debugging
psrvere Oct 15, 2024
096114d
minor fixes
psrvere Oct 16, 2024
7331d91
fixed integration tests
psrvere Oct 16, 2024
c3a087c
fixed linter checks
psrvere Oct 16, 2024
bb41309
Merge branch 'master' into websocket-qwatch
psrvere Oct 16, 2024
39687ef
fixed breaking tests
psrvere Oct 16, 2024
faee66b
fixed linter warnings
psrvere Oct 16, 2024
95baab4
merged with master
psrvere Oct 17, 2024
7a389a5
renamed qwatch to q.watch
psrvere Oct 17, 2024
ec04608
fixed qwatch tests
psrvere Oct 17, 2024
bd64c93
fixed json tests
psrvere Oct 17, 2024
4e44c01
fixed unit tests to use Q.WATCH
psrvere Oct 17, 2024
0544da0
minor fix
psrvere Oct 17, 2024
f7a8bc4
Merge branch 'master' into websocket-qwatch
psrvere Oct 18, 2024
97a4496
added warning failing to read message from client
psrvere Oct 18, 2024
4fc97a2
updated docs
psrvere Oct 18, 2024
96f10e0
merged with master
psrvere Oct 19, 2024
a90fceb
minor fix
psrvere Oct 19, 2024
930b5d9
Merge branch 'master' into websocket-qwatch
psrvere Oct 19, 2024
e281f70
Merge branch 'master' into websocket-qwatch
JyotinderSingh Oct 20, 2024
5a879ab
Merge branch 'master' into websocket-qwatch
psrvere Oct 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed unit tests to use Q.WATCH
  • Loading branch information
psrvere committed Oct 17, 2024
commit 4e44c019b1954012ab828641666b01a313d61196
8 changes: 4 additions & 4 deletions internal/server/utils/redisCmdAdapter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -388,14 +388,14 @@ func TestParseWebsocketMessage(t *testing.T) {
},
{
name: "Test simple QWATCH command",
message: "qwatch \"select $key, $value where $key like 'k?'\"",
expectedCmd: "QWATCH",
message: "q.watch \"select $key, $value where $key like 'k?'\"",
expectedCmd: "Q.WATCH",
expectedArgs: []string{"select $key, $value where $key like 'k?'"},
},
{
name: "Test complex QWATCH command",
message: "qwatch \"SELECT $key, $value WHERE $key LIKE 'player:*' AND '$value.score' > 10 ORDER BY $value.score DESC LIMIT 5\"",
expectedCmd: "QWATCH",
message: "q.watch \"SELECT $key, $value WHERE $key LIKE 'player:*' AND '$value.score' > 10 ORDER BY $value.score DESC LIMIT 5\"",
expectedCmd: "Q.WATCH",
expectedArgs: []string{"SELECT $key, $value WHERE $key LIKE 'player:*' AND '$value.score' > 10 ORDER BY $value.score DESC LIMIT 5"},
},
}
Expand Down