Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#803: Updating JSON.MGET command documentation #1085

Merged
merged 3 commits into from
Oct 16, 2024
Merged

#803: Updating JSON.MGET command documentation #1085

merged 3 commits into from
Oct 16, 2024

Conversation

paulodhiambo
Copy link
Contributor

Issue #803

@apoorvyadav1111 apoorvyadav1111 added the documentation Improvements or additions to documentation label Oct 14, 2024
apoorvyadav1111
apoorvyadav1111 requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thanks for the changes. I have left some comments.

docs/src/content/docs/commands/JSON.MGET.md Outdated Show resolved Hide resolved
docs/src/content/docs/commands/JSON.MGET.md Outdated Show resolved Hide resolved
docs/src/content/docs/commands/JSON.MGET.md Outdated Show resolved Hide resolved
docs/src/content/docs/commands/JSON.MGET.md Outdated Show resolved Hide resolved
docs/src/content/docs/commands/JSON.MGET.md Outdated Show resolved Hide resolved
docs/src/content/docs/commands/JSON.MGET.md Outdated Show resolved Hide resolved
apoorvyadav1111
apoorvyadav1111 requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for making changes as per comments. I have left one more comment.

docs/src/content/docs/commands/JSON.MGET.md Outdated Show resolved Hide resolved
apoorvyadav1111
apoorvyadav1111 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for closing this issue.

@apoorvyadav1111 apoorvyadav1111 changed the title Updating JSON.MGET command documentation #803: Updating JSON.MGET command documentation Oct 16, 2024
@apoorvyadav1111 apoorvyadav1111 self-assigned this Oct 16, 2024
@apoorvyadav1111 apoorvyadav1111 merged commit 7ce9316 into DiceDB:master Oct 16, 2024
1 check passed
kakdeykaushik pushed a commit to kakdeykaushik/dice that referenced this pull request Oct 19, 2024
@paulodhiambo @kakdeykaushik
DiceDB#803: Updating JSON.MGET command documentation (DiceDB#1085)
e5f9d04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvyadav1111 apoorvyadav1111 apoorvyadav1111 approved these changes

Assignees

@apoorvyadav1111 apoorvyadav1111

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulodhiambo @apoorvyadav1111