Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#838 Update/fix the documentation for BITCOUNT command #1083

Merged

Conversation

vaibspider
Copy link
Contributor

  • Reformatted the documentation
  • Validated all the examples and fixed an incorrect output value
  • Added missing parameter details to make it consistent with the code

- Reformatted the documentation
- Validated all the examples and fixed an incorrect output value
- Added missing parameter details to make it consistent with the code
@vaibspider
Copy link
Contributor Author

issue #838

@apoorvyadav1111 apoorvyadav1111 added the documentation Improvements or additions to documentation label Oct 14, 2024
Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the changes. have left some comments to ensure the documentation is consistent with other commands.

docs/src/content/docs/commands/BITCOUNT.md Show resolved Hide resolved
docs/src/content/docs/commands/BITCOUNT.md Outdated Show resolved Hide resolved
docs/src/content/docs/commands/BITCOUNT.md Outdated Show resolved Hide resolved
docs/src/content/docs/commands/BITCOUNT.md Outdated Show resolved Hide resolved
docs/src/content/docs/commands/BITCOUNT.md Outdated Show resolved Hide resolved
@apoorvyadav1111
Copy link
Contributor

Hi @vaibspider, thanks for making the changes. Please confirm if it's ready to be merged.

@vaibspider
Copy link
Contributor Author

@apoorvyadav1111 -- Yes, it's ready to be merged. I've done the changes you suggested.
Thanks for reviewing!

@apoorvyadav1111 apoorvyadav1111 changed the title Update/fix the documentation for BITCOUNT command #838 Update/fix the documentation for BITCOUNT command Oct 15, 2024
@apoorvyadav1111 apoorvyadav1111 merged commit 87c2d07 into DiceDB:master Oct 15, 2024
1 check passed
sashpawar11 pushed a commit to sashpawar11/dice that referenced this pull request Oct 15, 2024
kakdeykaushik pushed a commit to kakdeykaushik/dice that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants