Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized Readme for clipboard copy action. #1079

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Optimized Readme for clipboard copy action. #1079

merged 1 commit into from
Oct 13, 2024

Conversation

primeagen-rustaceans
Copy link
Contributor

#Problem

  • When copying the commands using the clipboard action button, $ also gets copied. This behavior hinders Readme file usage.

#Solution

  • Removed $ from the bash/shell/sh command snippets.
  • Marking every command snippet uniformly with bash.

@primeagen-rustaceans
Optimized Readme for clipboard copy action.
4010d60 
- When marking a code snippet with bash/sh, $ should ideally be ignored.
apoorvyadav1111
apoorvyadav1111 approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Approving 🚀.

@apoorvyadav1111 apoorvyadav1111 merged commit 8dc6e92 into DiceDB:master Oct 13, 2024
1 check passed
kakdeykaushik pushed a commit to kakdeykaushik/dice that referenced this pull request Oct 19, 2024
@primeagen-rustaceans @kakdeykaushik
Optimized Readme for clipboard copy action. (DiceDB#1079)
554a703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvyadav1111 apoorvyadav1111 apoorvyadav1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@primeagen-rustaceans @apoorvyadav1111