Add profiling for DiceDB #1048
Merged
Add profiling for DiceDB #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arpitbbhayani, PR for profiling DiceDB |
lucifercr07
requested changes
Oct 10, 2024
Closed
ed3b2f4 to
d07bc5f
Compare
|
@lucifercr07 have implemented your suggestions. Please let me know how they look. |
lucifercr07
reviewed
Oct 15, 2024
d07bc5f to
716f939
Compare
Signed-off-by: soumya-codes <151079203+soumya-codes@users.noreply.github.com>
716f939 to
34f157f
Compare
sashpawar11
pushed a commit
to sashpawar11/dice
that referenced
this pull request
Oct 15, 2024
Signed-off-by: soumya-codes <151079203+soumya-codes@users.noreply.github.com>
|
@soumya-codes What is the purpose of pushing the binary file "main"? |
That's a miss, will raise a PR to remove it. Thanks for pointing it out. |
|
@vinitparekh17 thanks for catching. I see @lucifercr07 has already raised a PR for this. |
kakdeykaushik
pushed a commit
to kakdeykaushik/dice
that referenced
this pull request
Oct 19, 2024
Signed-off-by: soumya-codes <151079203+soumya-codes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds profiling support for DiceDB
How to run profiling: