Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Documentation for JSON.ARRLEN Command(#782) #1003

Merged
merged 7 commits into from
Oct 10, 2024
Merged

Updated Documentation for JSON.ARRLEN Command(#782) #1003

merged 7 commits into from
Oct 10, 2024

Conversation

surya0180
Copy link
Contributor

@surya0180 surya0180 commented Oct 8, 2024 •
edited
Loading

Updated documentation (#782) after fixing some inconsistencies in JSON.ARRLEN command #974

  • Added Tables to display parameters, return values, etc.
  • Added extra examples to demonstrate several usecases
  • Added all possible errors
  • Made sure all headings and outputs follow SET command's documentation

@surya0180
Copy link
Contributor Author

@JyotinderSingh, @lucifercr07, @apoorvyadav1111. Please review this PR. Thanks!

@surya0180
Copy link
Contributor Author

This PR is made as a fix for #782 issue

@surya0180 surya0180 changed the title Updated Documentation of JSON.ARRLEN (#782) Updated Documentation for JSON.ARRLEN Command(#782) Oct 8, 2024
@surya0180
Copy link
Contributor Author

surya0180 commented Oct 8, 2024 •
edited
Loading

@lucifercr07 Looks like I made some mistakes before committing. Let me fix and update the PR quickly.

@surya0180
Copy link
Contributor Author

@lucifercr07 Updated the documentations after resolving the mistakes that you pointed out. Thanks!

@surya0180 surya0180 requested a review from lucifercr07 October 8, 2024 11:29
surya0180
surya0180 commented Oct 8, 2024
View reviewed changes
Copy link
Contributor Author

@surya0180 surya0180 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the requested changes. Please review them. Thanks!

JyotinderSingh
JyotinderSingh approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these documentation fixes, @surya0180! LGTM.

@JyotinderSingh JyotinderSingh merged commit b722b4e into DiceDB:master Oct 10, 2024
1 check passed
sashpawar11 pushed a commit to sashpawar11/dice that referenced this pull request Oct 13, 2024
@surya0180 @sashpawar11
DiceDB#782: Updated Documentation for JSON.ARRLEN Command (DiceDB#1003)
d7aaec3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JyotinderSingh JyotinderSingh JyotinderSingh approved these changes

@lucifercr07 lucifercr07 Awaiting requested review from lucifercr07

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surya0180 @lucifercr07 @JyotinderSingh