Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http Integration Tests: Create tests to support HTTP(7) #740

Closed
pratikpandey21 opened this issue Sep 26, 2024 · 4 comments · Fixed by #873
Closed

Http Integration Tests: Create tests to support HTTP(7) #740

pratikpandey21 opened this issue Sep 26, 2024 · 4 comments · Fixed by #873
Assignees

Comments

@pratikpandey21
Copy link
Contributor

This issue involves creating the below test cases for HTTP as well:

Source: integration_tests/commands/async/

  • hsetnx_test.go
  • hstrlen_test.go
  • hyperloglog_test.go
  • incr_by_float_test.go
  • incr_test.go

Steps:

  1. Create the corresponding tests for these commands in integration_tests/commands/http.
  2. Use set_test.go as a reference, and how to alter the input and output to match JSON structures from RESP.
  3. Run the tests and fix issues with command parsing in HTTP.

If you need to do anything custom to support HTTP, let @pratikpandey21 @lucifercr07 know.

@hgupta12
Copy link
Contributor

@pratikpandey21 can I take this up?

@lucifercr07
Copy link
Contributor

@hgupta12 assigned, thanks for contributing.

@arpitbbhayani
Copy link
Contributor

Hello @hgupta12,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

@hgupta12
Copy link
Contributor

hgupta12 commented Oct 3, 2024

Hey @arpitbbhayani , I have already opened a PR #873 to resolve this issue. I am done with implementing all the tests. There are a few errors which need to be resolved and I am working on them right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants