Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http Integration Tests: Create tests to support HTTP(4) #737

Closed
pratikpandey21 opened this issue Sep 26, 2024 · 6 comments
Closed

Http Integration Tests: Create tests to support HTTP(4) #737

pratikpandey21 opened this issue Sep 26, 2024 · 6 comments
Assignees

Comments

@pratikpandey21
Copy link
Contributor

This issue involves creating the below test cases for HTTP as well:

Source: integration_tests/commands/async/

  • echo_test.go
  • exists_test.go
  • expire_test.go
  • expireat_test.go
  • expiretime_test.go

Steps:

  1. Create the corresponding tests for these commands in integration_tests/commands/http.
  2. Use set_test.go as a reference, and how to alter the input and output to match JSON structures from RESP.
  3. Run the tests and fix issues with command parsing in HTTP.

If you need to do anything custom to support HTTP, let @pratikpandey21 @lucifercr07 know.

@harsh082ip
Copy link
Contributor

Can i take this up?

@lucifercr07
Copy link
Contributor

@harsh082ip assigned, thanks for contributing.

harsh082ip added a commit to harsh082ip/dice that referenced this issue Sep 27, 2024
harsh082ip added a commit to harsh082ip/dice that referenced this issue Sep 27, 2024
harsh082ip added a commit to harsh082ip/dice that referenced this issue Sep 27, 2024
@harsh082ip
Copy link
Contributor

harsh082ip commented Sep 27, 2024

#752

Hii @pratikpandey21 @lucifercr07 ,
can u please review this PR, I have completed 2/5 test cases for HTTP (i.e. for EXISTS and ECHO), I've also attached screenshots of test cases output as well
And I will create PR for remaining test cases soon
Please let me know if any changes are required

Regards,

harsh082ip added a commit to harsh082ip/dice that referenced this issue Sep 28, 2024
@harsh082ip
Copy link
Contributor

#752

Hii,
Can anyone please review my PR, I'm facing an error there regarding some checks

Regards,

@lucifercr07
Copy link
Contributor

Closing, merged as part of #752

@harsh082ip
Copy link
Contributor

Hii @lucifercr07 ,

Thank you for reviewing and merging the PR, but these two test cases are pending (i.e. expireat_test.go & expiretime_test.go)

I will create a PR for these by tomorrow

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants