Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent EXPIRE: EXPIRE with empty string as TTL should report an error #671

Closed
lucifercr07 opened this issue Sep 20, 2024 · 3 comments
Assignees

Comments

@lucifercr07
Copy link
Contributor

lucifercr07 commented Sep 20, 2024

Steps to reproduce

Run the commands mentioned in the test on Line 81 in the file https://github.com/AshwinKul28/dice-tests/blob/main/tcltests/unit/expire.tcl#L81.

Expected output

The expected output when the above set of commands when run on Redis

'*not an integer*'

Observed output

The observed output when the above set of commands when run on DiceDB

'ERR invalid expire time in 'expire' command'

The steps to run the test cases are mentioned in the README of the dice-tests repository.

Expectations for resolution

This issue will be considered resolved when the following things are done:

  1. Changes in the dice repository code to meet the expected behavior.
  2. Successful run of the tcl test behavior.

You can find the tests under the tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

@Abh-ay
Copy link
Contributor

Abh-ay commented Sep 20, 2024

@lucifercr07
can i take this up?

@AshwinKul28
Copy link
Contributor

@Abh-ay Thanks for picking this up. Assigned!

@Abh-ay
Copy link
Contributor

Abh-ay commented Sep 21, 2024

Hi @AshwinKul28 @lucifercr07
Just verify this command in redis and it accept -ve value also refer below ss
image
And In DiceDB we throw error as ERR invalid expire time in 'expire' command
Should we handle this or keep as it is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants