Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command HSTRLEN #655

Closed
arpitbbhayani opened this issue Sep 20, 2024 · 4 comments
Closed

Add support for command HSTRLEN #655

arpitbbhayani opened this issue Sep 20, 2024 · 4 comments

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the HSTRLEN command in DiceDB similar to the HSTRLEN command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@HassanAarzoo
Copy link

Please assign this to me

@lucifercr07
Copy link
Contributor

@HassanAarzoo assigned, thanks for contributing.

@c-harish
Copy link
Contributor

c-harish commented Sep 22, 2024

Hi @lucifercr07,
Since @HassanAarzoo is working on HEXISTS, let me take this.

Thanks

@JyotinderSingh
Copy link
Collaborator

Hi @lucifercr07,

Since @HassanAarzoo is working on HEXISTS, let me take this.

Thanks

Assigned @c-harish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants