Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command HSETNX #654

Closed
arpitbbhayani opened this issue Sep 20, 2024 · 4 comments
Closed

Add support for command HSETNX #654

arpitbbhayani opened this issue Sep 20, 2024 · 4 comments

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the HSETNX command in DiceDB similar to the HSETNX command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@shreyas23sk
Copy link
Contributor

Hey, I would like to work on this issue.

@arpitbbhayani
Copy link
Contributor Author

@shreyas23sk Thanks for taking this up. assigned.

@c-harish
Copy link
Contributor

Hi @shreyas23sk, are you still working on this? If not, I would like to take on this.

@shreyas23sk
Copy link
Contributor

Hey @c-harish , I am still working on this. I have made the requisite code changes and will raise the PR soon. Was a bit busy with college.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants