Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command BITFIELD #639

Closed
arpitbbhayani opened this issue Sep 20, 2024 · 6 comments · Fixed by #723
Closed

Add support for command BITFIELD #639

arpitbbhayani opened this issue Sep 20, 2024 · 6 comments · Fixed by #723

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the BITFIELD command in DiceDB similar to the BITFIELD command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@apoorvyadav1111
Copy link
Contributor

Hi @arpitbbhayani, Please assign this to me.

@arpitbbhayani
Copy link
Contributor Author

@apoorvyadav1111 Thanks for taking this up. assigned.

@anchalsinghrajput
Copy link

hi @apoorvyadav1111, are you still working on this issue? If not, Can I pick this up?

@apoorvyadav1111
Copy link
Contributor

Hi @anchalsinghrajput , I am working on this issue. If anything changes in the future, I will surely be updating here and will unassign myself.
Thank you

@arpitbbhayani
Copy link
Contributor Author

Hello @apoorvyadav1111,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

@apoorvyadav1111
Copy link
Contributor

Hi @arpitbbhayani , PR #723 has been created to address this issue. We are awaiting review and merging.
Thanks

JyotinderSingh added a commit that referenced this issue Oct 4, 2024
Co-authored-by: A Yadav <ayadav7@binghamton.edu>
Co-authored-by: Jyotinder Singh <jyotindrsingh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants