Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command ZRANK #1126

Closed
JyotinderSingh opened this issue Oct 17, 2024 · 3 comments · Fixed by #1137
Closed

Add support for command ZRANK #1126

JyotinderSingh opened this issue Oct 17, 2024 · 3 comments · Fixed by #1137

Comments

@JyotinderSingh
Copy link
Collaborator

Add support for the ZRANK command in DiceDB similar to the ZRANK command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@SyedMa3
Copy link
Contributor

SyedMa3 commented Oct 17, 2024

Can I work on this?

@JyotinderSingh
Copy link
Collaborator Author

Can I work on this?

Assigned, good to see you back @SyedMa3!

@SyedMa3
Copy link
Contributor

SyedMa3 commented Oct 17, 2024

Can I work on this?

Assigned, good to see you back @SyedMa3!

Glad to be back!
Created a PR.
Not 100% sure if I have covered all bases since the code has changed a lot from the last time! 😮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants