-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NapiProjekt provider #489
Conversation
This looks like a very complete PR. I'll review soon, thanks for your work. |
It was merged into master by error. I merged it to develop instead. |
when we can expect that napiprojekt.py provider will be added to master release ? |
@bogdal: the provider doesn't seem to work anymore. Unittests are failing: https://travis-ci.org/Diaoul/subliminal/jobs/88170450#L395 |
@Diaoul ok, I will check. |
@bogdal on provider level it means where and who can do it? Sickrage, subliminal or napiprojekt itself? Based on wikipedia :) srt subtitles should look like the ones downloaded from napiprojekt standalone app: https://en.wikipedia.org/wiki/SubRip |
The format you downloaded with subliminal looks like MicroDVD. Not sure why napiprojekt doesn't return consistent subtitle format, this should be handled by subliminal. |
I did some more checking. Additionally while browsing sites I came across dragon666 project called napi which includes a script to detect and convert subtitles format. |
Subliminal can detect a valid/invalid subtitle file with Line 157 in e0788be
It should be done when using the CLI, I wonder why it didn't happen here. I plan to develop a subtitle file format converter for any kind of format with a special focus on TTML for features. For now I think the best is to just discard them somehow and check why the result did get past the is_valid test with proper unittests. |
This PR adds NapiProjekt provider.
Fixes #384