Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two options for language name style in saved subtitles #1155

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

getzze
Copy link
Collaborator

@getzze getzze commented Jul 15, 2024

fixes #1022

Adds two options to the cli:

  • --language-type-suffix (boolean flag) to add an suffix to the saved subtitle if it's hearing impaired ("hi" suffix) or forced, only-foreign parts ("forced" suffix).
  • --language-format (string) to add the possibility to save with a 3-letter language code ("video.eng.srt" instead of "video.en.srt").

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  subliminal
  core.py
  subtitle.py
Project Total  

This report was generated by python-coverage-comment-action

@getzze getzze requested a review from ptrcnull July 26, 2024 22:05
@getzze getzze mentioned this pull request Jul 26, 2024
19 tasks
@getzze getzze merged commit 92a4022 into Diaoul:main Sep 9, 2024
20 checks passed
@getzze getzze deleted the subtitle-3-letter-lang branch November 25, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use 3 letter country code instead of 2
1 participant