Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various type hints around the detector #179

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

DominicOram
Copy link
Collaborator

Fixes #178

To test:

  • Confirm test still pass and type errors are reduced

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (611d2bc) 42.91% compared to head (11f5cbc) 42.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   42.91%   42.91%           
=======================================
  Files          45       45           
  Lines        3887     3887           
  Branches      752      752           
=======================================
  Hits         1668     1668           
  Misses       2095     2095           
  Partials      124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@noemifrisina noemifrisina merged commit 05f459b into main Feb 9, 2024
15 checks passed
@noemifrisina noemifrisina deleted the 178_correct_types branch February 9, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct image size type
2 participants