Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for copier templates #630

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Added support for copier templates #630

merged 3 commits into from
Mar 8, 2024

Conversation

M-Chan
Copy link
Contributor

@M-Chan M-Chan commented Jan 5, 2024

No description provided.

@M-Chan M-Chan self-assigned this Jan 5, 2024
garryod
garryod reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Have left a few small comments, the only one of significance is the source of plugin-scaffolder-backend-module-copier

backstage/packages/backend/package.json Outdated Show resolved Hide resolved
backstage/packages/backend/src/plugins/scaffolder.ts Outdated Show resolved Hide resolved
backstage/packages/backend/src/plugins/scaffolder.ts Outdated Show resolved Hide resolved
docs/requirements.txt Outdated Show resolved Hide resolved
@M-Chan M-Chan force-pushed the for_copier branch 2 times, most recently from 6dd11e2 to 2b7bf3a Compare January 18, 2024 15:00
@M-Chan M-Chan requested a review from garryod February 26, 2024 18:19
garryod
garryod requested changes Feb 27, 2024
View reviewed changes
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple little things, but nothing major. Any chance you could re-work the history to tell a nice story before we merge?

backstage/package.json Outdated Show resolved Hide resolved
backstage/packages/backend/src/plugins/scaffolder.ts Outdated Show resolved Hide resolved
@M-Chan M-Chan force-pushed the for_copier branch 10 times, most recently from 827655a to eb68b24 Compare February 27, 2024 11:22
@M-Chan M-Chan requested a review from garryod February 27, 2024 11:22
garryod
garryod requested changes Feb 27, 2024
View reviewed changes
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to figure out the resolutions in the package.json and could you fixup and of the autoformatting into the commit which added those lines of code?

@M-Chan M-Chan force-pushed the for_copier branch 3 times, most recently from bba59d4 to 22ed112 Compare February 29, 2024 15:15
@M-Chan M-Chan requested a review from garryod February 29, 2024 15:32
@M-Chan M-Chan force-pushed the for_copier branch 6 times, most recently from 23d53a5 to fef9f67 Compare March 1, 2024 14:36
@M-Chan M-Chan force-pushed the for_copier branch 2 times, most recently from 7dec60b to 502abed Compare March 8, 2024 09:00
garryod
garryod requested changes Mar 8, 2024
View reviewed changes
docs/requirements.txt Outdated Show resolved Hide resolved
M-Chan added 3 commits March 8, 2024 09:36
@M-Chan
Added dependencies and support for Copier
7be15e4 
added copier to install requirements

Added dependencies and support for copier plugin

added package dependency

for backstage plugin and copier compatibility

added missing dependency
@M-Chan
Scrape template(s) directly from Diamond's GitHub
eec142c
@M-Chan
don't specify containerRunner
22250c8
@M-Chan M-Chan merged commit 1759339 into main Mar 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garryod garryod garryod approved these changes

Assignees

@M-Chan M-Chan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-Chan @garryod